Evaluation export: sede show/hide toggle

Sub-tickets

Activity

• coder-venus-cc created · 1w ago
• coder-venus-cc note · 1w ago
  Sibling asks from the same client bundle (Puia, 2026-10-07): VENUS-481 (roster->dropdown), VENUS-482 (delegated authorship, blocked on PM ruling).
• coder-venus-cc note · 1w ago
  Elazar confirmed 2026-10-07: roster list is client-confirmed, work request is for venus (scope resolved, not a terra/venus ambiguity).
• coder-venus-cc note · 1w ago
  Verbatim client source (WhatsApp, Puia, 2026-10-07 15:18): 'Que en el espacio de evaluación exista la posibilidad de visualizar o no visualizar las sedes... al exportar en pdf.' Confirms scope as filed.
• coder-venus-cc completed · 1w ago
  SHA b3cf0421eff71e2d62edff51b042235c29fc0502, version 1.17.42
• audit-venus-ca audit-finding · 1w ago
  BLOCK:b3cf0421eff71e2d62edff51b042235c29fc0502. P2 incomplete entry point: /practicas/page.tsx:365-373 still links to alumno-historial PDF with no sede show/hide choice, while new toggle exists only on /informes/alumno/[id]. Preserve filtered-list export label/target/filter-scope notice and add the same choice there. P2 mobile layout: new checkbox+button groups at historial-pdf-button.tsx:13 and practica-detail.tsx:201 use nonwrapping flex; ficha header adds Back, PDF, edit/archive controls, risking overflow on narrow screens. Static source review only; generated PDF and rendered mobile layout not exercised.
• audit-venus-ca audited · 1w ago
  audit fail: Static code review of b3cf0421 VENUS-480 PDF sede toggle; changed files read in full plus other historial export entry point; no browser/PDF render execution
  payload

  {"scope":"Static code review of b3cf0421 VENUS-480 PDF sede toggle; changed files read in full plus other historial export entry point; no browser/PDF render execution","outcome":"fail","evidence":"route.tsx hides historial Sede column and ficha Sede field/header/filename for sede=0, preserving default show. But /practicas/page.tsx:365-373 still exposes the same alumno-historial PDF with no toggle. New checkbox/button groups at historial-pdf-button.tsx:13 and practica-detail.tsx:201 do not wrap and can overflow narrow mobile widths. Finding recorded separately. No new-parameter PDF output test or rendered mobile proof in this review.","reportRef":null}

• coder-venus-cc note · 1w ago
  Audit fixup pushed: sha 097ee72bdfa2, v1.17.42, deploymentId dpl_6NcAy9gpgPDCZktkBF7NPkudZqsi matched. Fixes audit-venus-ca P2s: extended sede toggle to /practicas historial export (HistorialPdfButton reused with label/target props), flex-wrap added to practica-detail.tsx and practicas/page.tsx header control groups.
• audit-venus-ca audit-finding · 1w ago
  BLOCK:097ee72bdfa2d3afbf468256693a705113720901. Fixed /practicas historial toggle and parent flex-wrap, but the reused long name-dependent export label is still rendered inside shared Button's whitespace-nowrap class (ui/button.tsx:11). A flex-wrapping parent cannot wrap that child, so mobile can still overflow for ordinary/long alumno names. Give the asChild export Button max-w-full, height-auto, whitespace-normal, break-words and text-center or use a responsive short label. Static source review; no browser rendering.
• audit-venus-ca audited · 1w ago
  audit fail: Static re-review of 097ee72 fix-forward for two P2 UI findings; no browser rendering or PDF byte inspection
  payload

  {"scope":"Static re-review of 097ee72 fix-forward for two P2 UI findings; no browser rendering or PDF byte inspection","outcome":"fail","evidence":"The /practicas historial entry point now uses HistorialPdfButton with its prior label/target/filter notice and both control groups flex-wrap. Remaining issue: HistorialPdfButton's dynamic /practicas export label is inside shared Button's whitespace-nowrap class, so the long name-dependent button can exceed narrow viewport width despite parent flex-wrap. Finding recorded separately.","reportRef":null}

• coder-venus-cc note · 1w ago
  Audit fixup 2 pushed: sha 9dcd7f193992ff5bd3bd59f09097c2f3b93787d7, v1.17.42, deploymentId dpl_7zbWwN3oz9kqQDZaVjoMkUo2FgDd matched. Fixes remaining P2: HistorialPdfButton's asChild Button now wraps a long label (h-auto max-w-full min-w-0 whitespace-normal break-words) instead of overflowing on narrow viewports.
• audit-venus-ca audited · 1w ago
  audit pass: Static source re-review of final 9dcd7f1 fix-forward, considered with b3cf042 and 097ee72; no browser or generated PDF inspection
  payload

  {"scope":"Static source re-review of final 9dcd7f1 fix-forward, considered with b3cf042 and 097ee72; no browser or generated PDF inspection","outcome":"pass","evidence":"The route uses sede=0 to omit the historial Sede column and ficha Sede field/header/filename while default links still show it. Both historial export entry points expose the toggle; /practicas keeps its label, target and filter-scope notice. Header groups flex-wrap. Final HistorialPdfButton asChild Button overrides shared whitespace-nowrap with h-auto max-w-full min-w-0 whitespace-normal break-words text-center, allowing dynamic long names to wrap. Prior fail verdicts are superseded for this final source state. Rendered mobile layout and PDF bytes remain unexercised.","reportRef":null}