sendWelcomeEmail is dead code — a welcome email the product believes it sends and has never sent once
DEAD-CODE FINDING IN ITS OWN RIGHT, split out of VENUS-333 by pmmaster ruling (ms83loehzop6). src/lib/email.ts:96-157 sendWelcomeEmail has ZERO CALL SITES -- grep -rn over src+scripts returns exactly two hits, its own export and its own failure-log line. The subject string 'Bienvenido a Evolutiva Venus' occurs nowhere else in the tree. So VENUS HAS NEVER SENT THAT MAIL TO ANYONE. Double-unreachable: email.ts:1 is import 'server-only', so a tsx script throws at import -- unreachable from the app AND from the CLI. That over-determination is deliberate to state: it closes the CLI workaround before anyone proposes it. DECIDE THE DISPOSITION, do not assume: either wire it to a real path (which onboarding step should send it?) or delete it -- a function the product believes it sends is worse than one that is absent, because every reader downstream assumes new users are welcomed. NOTE the adjacent live defect already tracked at VENUS-334 (inviteTitular's alreadyExisted branch asserts a successful send regardless of emailSent) -- the two are on the same surface but are separate changes. Found by coder-venus-cc while discharging VENUS-333's constraint 5. Owner coder-venus-cc.
Questions
Activity
-
completed