EVO-54: inventory isDemo/demo-* gates + demo seed rows in prod (Phase 1, no deletes)
Done normal
unassigned
Elazar directive via pmmaster-evolutiva-cc 2026-07-17: fleet demo-data debt retirement. Demo/seed data (throwaway for pre-launch client testing) became permanent debt - isDemo/demo-* gates scattered in code + demo periodo/comisiones/user rows in prod, will NEVER be recreated. Phase 1 = INVENTORY ONLY (enumerate every isDemo/demo-* gate in code + every demo seed row in prod DB). NO deletes. Report inventory to pmmaster; purge-vs-keep decision comes after Elazar sees all 3 app inventories.
Questions
No questions.
Activity
-
db-venus-cc DB inventory: ZERO demo rows in prod venus DB. Checked 6 isDemo-bearing tables (alumnos, practicas, practicaParticipations, users, pacienteAntecedentes, userRoles) = 0 each; createdVia='demo_seed'=0; @demo.venus emails=0. sedes/modulos/titularSedes/periodos have no isDemo column (no mechanism to hold demo rows). Consistent with the never-seeded-on-prod guardrail. Awaiting coder-venus-cc's code-gate inventory before relaying combined report to pmmaster.
-
coder-venus-cc code inventory: shared/reports/2026-07-17-venus262-isdemo-gate-inventory.md — 3 behavioral gates (allowlist, demo-only password login, outbound-mail demo-reject), 2 cron view-filtered recipient sites, vActive* views bake isDemo=false filtering at DDL level (4 silent-reliant read sites), 2 real-INSERT isDemo=false stamps, 2 display-only, 2 seed scripts (seed-demo.ts, seed-test-users.ts). Combined with db-venus-cc's zero-rows-in-prod finding, relayed to pmmaster.
-
Phase 1 inventory complete, both legs reported: DB=zero demo rows/no seed ever ran on venus prod; code=11 numbered findings across 6 categories (3 behavioral gates, view-baked filters, INSERT stamps, display, seed scripts). Full report: shared/reports/2026-07-17-venus262-isdemo-gate-inventory.md. Relayed to pmmaster for cross-app purge-plan decision.
-
parent=#2067
-
Reopened for Phase 2: Elazar GO (nqla #2) on gate-strip with hard guard - full team review required, must confirm no gate backs Elazar's multi-role view-as/impersonation path before removing.
-
coder-venus-cc Phase 2 review: NOT a clean strip — 3 of 11 gates back the persona/view-as path (email-recipient-guard demo-block, 2 cron-view persona filters, vActive* isDemo filter conditionally hides personas). Queried db-venus-cc whether personas are isDemo=true/@demo.venus. Design-pinged audit-venus-ca with the split. SAFE-to-strip (pure demo-debt): password-login @demo-only gate, allowlist whitelist, INSERT isDemo stamps, display surfaces, both seed scripts. VENUS-111 accountableActorId confirmed untouched. Awaiting db facts + team agreement before push.
-
coder-venus-cc HALTED strip, no code touched. /puia (src/app/puia/page.tsx) is Elazar's deliberate hidden multi-role test-login URL, fed by seed-test-users.ts @demo.venus password accounts — NOT demo-debt, part of his test-login feature. password-login @demo gate is a RESTRICTION (limits login to @demo); removing it would OPEN password login to all domains = security regression. Combined with db/audit's already-flagged persona-entangled gates, residual safe-strip shrinks to cosmetic-only (INSERT isDemo=false stamps → column default) — not worth Class-A churn. Recommend: push nothing, bounce scope to Elazar to confirm what 'demo-debt' means given /puia + seed-test-users stay.
-
Blocked on Elazar: scope clarification needed. coder-venus-cc found /puia (src/app/puia/page.tsx) is Elazar's own deliberate hidden multi-role test-login URL, fed by seed-test-users.ts @demo.venus password accounts — not demo-debt. Stripping the @demo password-login gate would OPEN login to all domains (security regression, not a strip). Residual safe-strip after excluding this + already-flagged persona pieces = cosmetic only. Bounced to pmmaster/Elazar: what does 'demo-debt' mean given /puia stays.
-
Settled (Elazar delegated to coder-venus-cc, disposition 2026-07-17): NO code change. /puia + seed-test-users + password-login STAY (Elazar-authored test-login feature). @demo password-login gate STAYS (it's a login RESTRICTION; removing opens login fleet-wide = security regression). Residual = 2 cosmetic isDemo=false INSERT stamps, redundant with the column DEFAULT false; dropping them is a zero-behavior no-op but the INSERTs are user-provisioning paths so a removal push is Class-A - not worth a Class-A cycle for pure cosmetics. Stamps left as harmless/self-documenting. SEPARATE finding: /puia non-functional today (public.users backing rows absent) - restoring needs db-venus re-run seed DB half; flagged to Elazar as its own decision.
task
4w ago by wi-cli-venus
4w ago
2026-07-17 10:29