movilba
MOVILBA-798
Bus Alta: make ID CANBUS optional and store 0 when blank
In progress high
cmcoder04-mba-l-ca
Elazar reports DEV /vehiculos/agregar/colectivo requires ID CANBUS, but daily bus Alta must permit it blank and persist ip_canbus='0' (not NULL). db04 measured 5,319/5,571 current RUTAP rows id_canbus='0', PROD bus rows 2,269/2,433 and DEV 2,290/2,464 ip_canbus='0' (plus 7 blank DEV); nonzero is not universal. Scope app form/service/repository mapping only unless DB says otherwise; blank -> literal 0, explicit nonblank value preserved, focused tests for both. Audit focused review, ship PROD/DEV/pod same task, authenticated Alta validation. Avoid touching unrelated required-field rules.
Activity
-
Current DEV v5.6.251 app correction ready for focused audit; no DB write or deploy.
-
Current DEV release clone HEAD 19bed48d (v5.6.251), 4 scoped app files under exact path locks. Alta form removes ID CANBUS required marker/attribute; createColectivo removes only ipCanbus from requiredFields and maps empty/whitespace to literal '0' without modifying nonblank text; repository INSERT defaults blank to literal '0', not NULL. Focused action test covers '', spaces, undefined, explicit LOCAL-CANBUS and explicit 0; source guard covers optional input and repository fallback. All other required fields remain in the existing test loop. Pins: page 663ac8fdf3d2ac6847ab3a7857773184afc7c57f192b15b714031a08b7ab8b87, service 5a510037579de995188e6eb78a4d1fcb315afc73d5a7a34d090bc2688b06bc87, repository 81221ac441e7285350ed8b89b8ffd489d1060eb8647b54a9a7647b919bfabb54, focused test 747418942d42806a77fc99d95de86c8bd9f4147ac2444afbb9138427f157ac2f. git diff --check rc0; tests/lint/typecheck delegated to audit per AGENTS.md. No live Alta or DB write.
-
Additional source-flow check after db04's SELECT-only DB caveat: createColectivo writes VDC ipCanbus='0' at repository :993, then in the SAME transaction columnasDesdeFicha(tx,newVehiculo.id) reads d.ip_canbus at :245 and its result is spread into the initial rutap.vehiculo_historial_normalizado INSERT at :1032-33. Therefore both VDC and app history get the inserted value in code flow; no second history mapping edit needed. This is source evidence only, not a live DB write. Four audit pins unchanged.
-
audit pass: Frozen HEAD 19bed48d; reviewed four pinned files. Ran old-source negative control, focused test 27/27, test:source 73/73, typecheck, targeted ESLint, diff-check. No live DB/browser create.
payload
{"scope":"Frozen HEAD 19bed48d; reviewed four pinned files. Ran old-source negative control, focused test 27/27, test:source 73/73, typecheck, targeted ESLint, diff-check. No live DB/browser create.","outcome":"pass","evidence":"PASS. Old-source control exited 1: blank-CANBUS behavior and optional-form assertions failed. Candidate passed 27/27; blank/whitespace/undefined map to literal '0', nonblank preserved, direct repository callers guarded; no other required rules changed. Source flow also carries VDC ip_canbus into initial app history in the same transaction (not live-write tested). Typecheck, ESLint, test:source and diff-check passed. Node v24.21.0 vs requested v24.14.1.","reportRef":null} -
Focused audit PASS on frozen HEAD 19bed48d recorded by audit-mba-l-ca; pre-change control failed, focused 27/27, test:source 73/73, typecheck, targeted ESLint and diff-check passed. All four file hashes rechecked unchanged after verdict. SHIP handoff sent to coder03-mba-l-ca, who owns deploy. No live browser/DB Alta yet; authenticated blank-CANBUS create remains the after-control.
-
Focused audit PASS. App v5.6.252 shipped: DEV commit cb091a12 health/current; PROD merge 677f3f11 health/current; OpenShift GitLab develop mirror push + Tekton EventListener HTTP 202 accepted, live pod build still pending verification. Code tests blank/whitespace/undefined ID CANBUS -> literal '0', explicit value preserved in VDC and initial history. No live blank-CANBUS Alta exercised yet.
-
Elazar prioritizes DEV+PROD over POD on 2026-10-14. Fresh public health checks show PROD and DEV status ok/serviceId 35435 = v5.6.252. Optional CANBUS blank->'0' app code is deployed there with focused audit PASS and deploy gates green. Pod mirror/Tekton trigger accepted but public endpoint still reported v5.6.251 at 11:29 ART; pod parity deferred as low priority per Elazar. No live blank-CANBUS Alta has been exercised; verify on next legitimate creation.
bug
2d ago by coder03-mba-l-ca
2d ago