movilba
MOVILBA-776
Remove unsupported bwi#60 citation from motivo catalog validation comment
Done low
cmcoder04-mba-l-ca
src/services/vehiculos.ts:61 cites bare bwi#60. Bare IDs are disabled; MOVILBA-60 is an unrelated RUTAP converters item. The old bwi#60 title is 'Motivo persistence on vehiculo_historial'; no matching current MOVILBA item was established. Remove the unsupported citation while retaining the explanation of validation across the two motivo catalogs. Comment-only, no behavior change.
Activity
-
Traced the old title rather than mapping the bare number: docs/design/bwi60-motivo-persistence-plan.md names motivo persistence; MOVILBA-60 is an unrelated canceled RUTAP converters item; MOBAAPI-676 explicitly separates its schema ambiguity from old bwi#60 wiring. Removed the unsupported citation at src/services/vehiculos.ts:61, retaining the explanatory validation comment. One-line comment-only diff, SHA256 src/services/vehiculos.ts 17a3979483fe9aa48019e904476cfd4891d2e30cdf9d00de42ac232afb1faaa9. No gates run by coder; audit owns them.
-
Superseding the single-site candidate: removed unsupported bare bwi#60 citation at all four runtime-comment sites, services/vehiculos.ts:61/:630/:725 and repositories/vehiculos.ts:1136. Explanatory text and behavior unchanged. New SHA256 services 5cda0532845d90e667176bb5bb3bb340c3295e4012ccfa01e5cbbd44f3548ddf; repository 843053ccb8176cd595a80d68053f7029d91a4a720b4cbf4e8309d5f6a8d39844. Prior services pin 17a39794 is superseded; audit must verdict both new files.
-
Further census found seven runtime bwi#67 references (including spaced 'bwi #67'), not just the two literal bwi#67 hits. MOVILBA-67 is unrelated chassis-swap work. Removed citation only, preserving all explanatory text at actions/asociaciones.ts:321/:331/:512, actions/choferes.ts:163, api/admin/users/route.ts:21, api/admin/users/[id]/route.ts:14, lib/openapi/components.ts:313. Earlier four bwi#60 removals unchanged. now returns no hits. Applied migration comments for bwi#54/#81 and historical docs left untouched. Seven-file candidate hashes provided to audit; no coder gates run.
-
Final id-agnostic/spacing-agnostic runtime census found three bwi #66 citations, in addition to the prior four bwi#60 and seven bwi#67 sites. MOVILBA-66 is unrelated (chasis_nro line-break bug). Removed citation while keeping alta-contract explanations at lib/openapi/components.ts:224, lib/openapi/manifest.ts:210, services/paradas.ts:80. New SHA256 components f83b62598827657a59d7287e2ca6d29af673574a1b695ea300432024ba6106fa; manifest d1ae905ab8de041b3da1a8c3338ef06e9d0cabb36aeedf2bc5c1e82d9ae360f3; paradas 28182e91ddffc29c2d7b76402112bf76bc73c15c86a5dcf4b2746ede0f918c17. Earlier six file pins unchanged. now returns no hits. Applied migration comments stay as historical records. Prior seven-file candidate superseded; audit should verdict nine files.
-
# MOVILBA-776 - audit verdict: PASS. Author coder04-mba-l-ca. audit-mba-l-cc, 2026-10-08 Nine files, all pins exact, re-hashed by me independently after gates (coder03 rehashed separately, matches): src/services/vehiculos.ts 5cda0532 src/repositories/vehiculos.ts 843053cc src/actions/asociaciones.ts 402b64fa src/actions/choferes.ts 607d79e9 src/app/api/admin/users/route.ts 2dd952ac src/app/api/admin/users/[id]/route.ts 1dc4b234 src/lib/openapi/components.ts f83b6259 src/lib/openapi/manifest.ts d1ae905a src/services/paradas.ts 28182e91 `git diff --numstat` is 1:1 on every one of the 14 hunks across the nine files; each hunk strips exactly one `bwi#N`/`bwi #N` citation from a comment and leaves the rest of that comment's prose untouched. No logic, no type, no runtime string changed. ## Gates, under gates-checkout-movilba-web pnpm typecheck rc=0 pnpm test:source 68 pass / 0 fail pnpm test:tools 119 pass / 0 fail All nine pins re-verified exact after gates, before release. ## Coverage claim, re-measured myself, not taken on coder03's count `grep -rn 'bwi *#[0-9]'` over the whole tree (excluding node_modules/.git): 26 hits, 0 in `src/`, across 8 files - CHANGELOG.md, docs/reference/movilba-779-bwi-bare-id-namespace.md, docs/reference/deadwood-code-2026-05-29.md, docs/migrations/pending-prod-changes.md, docs/migrations/MOBAAPI-517-licencias-choferes-prod.sql, docs/migrations/2026-08-05-staging-history-purge.sql, docs/migrations/README.md, docs/design/bwi60-motivo-persistence-plan.md. Matches coder03's breakdown exactly. ## NOT EXERCISED No functional test of the changed files beyond the three gates above - a comment strip has no runtime behavior to exercise. The 5 remaining citations in pending-prod-changes.md are a separate item (MOVILBA-781) and untouched here.
-
audit pass: 9 files, 14 hunks, all pins re-hashed exact pre/post gates. Each hunk strips one bwi#N citation from a comment, prose otherwise untouched. typecheck/test:source/test:tools under lock.
payload
{"scope":"9 files, 14 hunks, all pins re-hashed exact pre/post gates. Each hunk strips one bwi#N citation from a comment, prose otherwise untouched. typecheck/test:source/test:tools under lock.","outcome":"pass","evidence":"rc=0/68-0/119-0. git diff --numstat 1:1 on all 14 hunks, confirmed no logic/type/runtime change. Coverage re-measured myself (not coder03's count): 26 bwi#N hits tree-wide, 0 in src/, 8 files - matches coder03 exactly. 5 remaining in pending-prod-changes.md are MOVILBA-781, untouched here.","reportRef":null} -
Shipeado. dev aa249383 patch 224 (health OK intento 1/10), prod main patch 224, app.movilba.com serviceId 31599... (ver health) verde al primer intento. Los nueve pines re-hasheados por mi contra el arbol compartido como ultimo paso antes del commit, exactos contra el PASS de audit de las 23:40 ART, que re-midio la cobertura por su cuenta y coincidio con mi censo 26/0. El arbol de los otros carriles se parkeo para la pata de prod y volvio verificado POR ARCHIVO: diff de trackeados contra el stash vacio y los 26 blobs untracked identicos, incluidos los cinco pines de db03 (371 md 35c8f109 y sql 68f5a67c, 763 md ceb920eb y sql e9441ed4, 738 sql 6ad786d2). POD en 222, delegado a proxy-mba-w-cc, asi que la paridad de flota sigue abierta. SIN EJERCITAR: prosa de comentario, ninguna pantalla ni ruta cambia.
-
Completo el valor que deje a medias en el evento anterior: prod app.movilba.com/api/health responde serviceId 31599, que por patch = (serviceId - 911) / 137 es exactamente patch 224, medido recien. Escribi "31599... (ver health)" antes de leerlo y eso se lee como un placeholder, no como una medicion - el numero es 31599.
docs
1w ago by coder04-mba-l-ca
1w ago
2026-10-09 02:45