Ocho archivos y 14 capturas descartan el requestId emitido por el servidor
Done normal
unassigned
Mitad de arreglo del censo de MOVILBA-741 (cerrado, solo medicion). researcher midio: de los 13 archivos que marco MOVILBA-407, 8 archivos / 14 sitios de llamada descartan genuinamente el id del servidor - capturan la excepcion, no extraen requestId y no llaman log() en absoluto. Es una forma DISTINTA de la de 407, que minteaba un id nuevo en lugar de extraer el que ya venia. Descartados por researcher y fuera de alcance de este item: 2 falsos positivos ya cableados correctamente por isApiError aunque no por los dos helpers nombrados, 2 fuera de alcance (uno sin llamada de red, uno correcto con un problema menor no relacionado), y 1 de los 13 originales eliminado porque el hit del grep era un comentario en castellano y no un bloque catch. 8+2+2=12 de 13. LIMITE DE COBERTURA heredado de 741: el censo salio de un grep por helper nombrado, asi que un sitio que resuelva el id por un camino que no sea isApiError ni los dos helpers puede no estar en los 13 de partida.
Activity
-
parent=#3560
-
Starting the 14-site catch/no-extraction/no-log slice while MOVILBA-465 is under audit; checkout writes wait until audit releases gates-checkout-movilba-web.
-
Ocho archivos y 14 capturas descartan el requestId emitido por el servidor
-
Scope correction before implementation: the 14 sites are the server-requestId discard population, not 14 sites with no log whatsoever. In src/app/admin/opciones/[id]/page.tsx:89-99, the first catch DOES call log(), but uses the locally minted per-attempt requestId instead of the server ID; this is the one call site with a mismatched log ID. The other 13 do not call log(). Preserve this distinction in the code and audit scope.
-
Parked while the PASSed MOVILBA-465 diff is shipped first; resume after the exact-path SHIP clears.
-
Checkout lock granted; reconciling the 14 census sites against current tree before implementing server requestId propagation.
-
Implementation ready for audit (2026-10-08). Current-tree reconciliation: the two src/app/admin/carrocerias/agregar/page.tsx catches already pass isApiError(err).requestId into ErrorModal, so they were left unchanged; the other 12 sites were updated across seven paths to carry requestIdDelServidor(err) into the visible error, and admin/opciones/[id] now uses the server id for the load-error log instead of its client attempt id. The raw-fetch verify-email response now surfaces error.requestId; network failures only carry an id if the thrown value has one. No lint/typecheck/tests run before audit per coder handoff rules; git diff --check passed. Exact changed-path SHA-256: src/app/admin/audit-log/page.tsx f7504ac129829d3b3937231549c2123864947bd3f41e913d39b2e09c67ddcf0b; src/app/admin/opciones/[id]/page.tsx 1fed51fce85c5ece6eb84b7d3cfdec94c8a28b5cf267eb12d9f90f50c59f697a; src/app/auth/verify-email/page.tsx f5c1f4188403e51b25615965b04770fce25434222fc25881220ee34c1692a535; src/app/entidades/[id]/page.tsx 4a98dccde4f4575a6ebe50d2191d4d6eee71a9c1382c45f13e1caf17fa596f37; src/app/reset-password/page.tsx 8185dfdc894bf87894d29ed4848e4a82b2ee033e7fbc1b00eeca9935659b9247; src/app/user/login/LoginForm.tsx b18e8f84b1b9b8323f99a85a2ce8e7a02a7ff5a256637134b0c83facf90dc941; src/app/vehiculos/page.tsx 0120016ac03ec8e5c66d74183ec58d9702ed5be3ab97a74de9b3bf05f227bebf.
-
Implementation is handed to audit; waiting for its scoped verdict on the seven changed files.
-
Reviewed all 7 changed files: audit-log/page.tsx, admin/opciones/[id]/page.tsx, auth/verify-email/page.tsx, entidades/[id]/page.tsx, reset-password/page.tsx, user/login/LoginForm.tsx, vehiculos/page.tsx. All 7 SHA-256 pins from the 2026-10-08T22:25:24.228Z handoff note confirmed exact against working tree. Each site now extracts requestIdDelServidor(err) from the caught error instead of minting a fresh client id, or (admin/opciones) falls back to the locally-minted id only when the server did not supply one. Cross-checked two non-obvious shape assumptions: (1) verify-email/page.tsx's new data.error?.message/data.error?.requestId parsing matches createErrorResponse's real ApiErrorResponse shape {error:{code,message,details,requestId}} in src/lib/errors.ts:153-185; (2) entidades/[id]/page.tsx's swap of notFound() for <ErrorPage type="notfound" requestId=.../> matches ErrorPage's actual prop shape in src/components/ErrorPage.tsx. Confirmed src/app/api/dropdowns/route.ts's concurrent git-status change is an unrelated MOVILBA-767 comment edit, correctly out of scope. Gates: pnpm typecheck rc=0 (next typegen + tsc --noEmit clean); pnpm test:source 71/71 pass; pnpm test:tools 120/120 pass. No defects found.
-
audit pass: all 7 changed files reviewed in full diff; typecheck, test:source, test:tools run
payload
{"scope":"all 7 changed files reviewed in full diff; typecheck, test:source, test:tools run","outcome":"pass","evidence":"7/7 SHA-256 pins exact; ApiErrorResponse and ErrorPage prop shapes cross-verified against source; typecheck rc=0, test:source 71/71, test:tools 120/120; dropdowns/route.ts change confirmed out of scope","reportRef":null} -
audit pass: 7 changed files, requestId extraction at 8 sites/7 files + ApiErrorResponse/ErrorPage shape cross-check
payload
{"scope":"7 changed files, requestId extraction at 8 sites/7 files + ApiErrorResponse/ErrorPage shape cross-check","outcome":"pass","evidence":"typecheck rc=0, test:source 71/71, test:tools 120/120","reportRef":null} -
Shipped PROD+DEV, both patch 246, by coder03. Commit e20ca171 (prod)/ef724474 (dev).
-
cleared: Implementation is handed to audit; waiting for its scoped verdict on the seven changed files.
-
completed
task
1w ago by coder03-mba-l-cc
1w ago
2026-10-09 14:58