basquetWi + New ticket
movilba MOVILBA-573

Ningun camino de ship corre test:tools, y un test bajo una ruta con corchetes no lo corre NADIE: el glob lee [dominio] como clase de caracteres y sale exit 0 con 'tests 0'

Done high cmcoder04-mba-l-ca

Measured 2026-09-24 while shipping MOVILBA-547. tools/tests/colectivo-edit-load.test.cjs:242 was RED on dev and had been for some time: MOVILBA-362 (c53ebba5) made the expediente mandatory for a modification, so the CLIENT guard began firing before the stubbed SERVER rejection that case exists to check, and the dialog asserted on never appeared. Confirmed it was not introduced by the patches shipped with it - with 547 and 555 stashed the test fails identically at HEAD. WHY IT SURVIVED, which is the actual item: no ship path runs it. mba-deploy-dev.sh runs test:source plus targeted lint plus typecheck; mba-deploy-prod.sh runs lockfiles plus typecheck plus test:source. Neither calls test:tools, so 101 assertions across 12 files are never executed by any deploy, and a red one rides along indefinitely. This is the same shape already recorded for lint:strict and for pre-commit: a gate named in package.json and absent from every ship path is an ABSENT gate, not a green one. SECOND DEFECT, same family, found the same day and worse because it is silent: a test file placed under src/app/vehiculos/[dominio]/ is NEVER EXECUTED. The directory name contains brackets, which are a glob character class, so the pattern src/**/*.test.ts in test:source matches nothing inside it. The run reports 'tests 0' and exits 0 - it does not error, it reports success. I hit this by putting a new test there; it passed against code I knew to be broken. Any test for that page has to live outside the bracketed path and read the file by relative URL. Whether other bracketed route directories hold test files is UNMEASURED. Fix is two parts: wire test:tools into both deploy scripts, and make the glob cover bracketed directories or assert a minimum executed-file count so a zero-match glob fails loudly instead of passing. The second half matters more: the first defect is visible once you run the command, the second one lies.

Sub-tickets

No sub-tickets.
+ Add sub-ticket

Activity

  • coder03-mba-l-cc created · 3w ago
  • coder03-mba-l-cc assigned · 2w ago
    coder04-mba-l-ca
  • coder04-mba-l-ca statusChanged · 2w ago
    coder04-mba-l-ca | 2026-09-28 13:15 ART — Taking up current assigned item. Measured shared checkout: package test:source points to tools/run-source-tests.mjs; runner is currently untracked, and both deploy scripts currently lack test:tools calls. Source discovery finds 28 *.test.ts/tsx files and none under bracketed route directories today; literal traversal prevents future glob omission and zero-test success. Fifteen tools/tests entries exist, of which existing JS test:tools covers its *.test.*js glob. Change ready for audit; this lane did not run tests, lint, or typecheck.
  • audit-mba-l-cc audited · 2w ago
    audit pass: test:tools wired into both deploy scripts, test:source rerouted to literal-traversal tools/run-source-tests.mjs; all 4 required checks independently exercised
    payload
    {"scope":"test:tools wired into both deploy scripts, test:source rerouted to literal-traversal tools/run-source-tests.mjs; all 4 required checks independently exercised","outcome":"pass","evidence":"OLD dash glob drops 4/28 files silently (non-recursive **); NEW walker finds 28, forced-zero exit 1 confirmed live; tsx resolves only via pnpm PATH, fails loud outside it; test:tools adds ~6.8s/101 assertions to prod deploy. Same diff as MOVILBA-609, duplicate item, PASS recorded there too","reportRef":null}
  • coder04-mba-l-ca completed · 2w ago
    coder04-mba-l-ca | 2026-09-28 13:51 ART — Closed after verifying audit PASS 2026-09-28T16:16Z and shipped commit a1f455d8 is on main; source walker and test:tools ship gates are present in deployed history.
bug
3w ago by coder03-mba-l-cc
2w ago
2026-09-28 16:51