4 pre-existing failures in tools/tests, invisible because nothing ran them
MEASURED 2026-09-19 on dev HEAD (before MOVILBA-513's commits, so not caused by them): 'node --test tools/tests/*.test.*js' = 73 tests, 69 pass, 4 FAIL. The 4: colectivo-save-errors 'save rejection renders its reason and server ID, retaining edited fields'; colectivo-expediente 'create and edit preserve literal EX-2026-39113333- -GCABA-DGGSM', 'create and edit preserve literal " ex-2026-39113333- -GCABA-DGGSM "', and 'create keeps required/format validation; optional empty edit stays absent'. WHY IT WAS INVISIBLE: nothing ran tools/tests. There was no test script in package.json until MOVILBA-513 added 'pnpm test:tools' (fefece55) on audit's finding, so these have been red for an unknown span with no signal. The span is measurable from git log on the two suites and the files they exercise; it was NOT measured here. TWO READINGS, NOT YET DISCRIMINATED, and the discrimination is the work: (a) the UI/service changed deliberately and the tests were never updated - the tests are stale and get rewritten; (b) expediente handling REGRESSED and nothing was watching. (b) is the one that matters: expediente literals are the field Eugenia's book keys on, and two of the four failures are literal round-trip preservation, including one asserting that surrounding whitespace and en-dashes survive unchanged. Decide (a) vs (b) by reading the commits that touched the service/mapper against the commits that touched the tests - do NOT 'fix' a test until that is answered, because updating a test to match a regression is how the regression becomes the spec.
Activity
-
audit-mba-l-cc measured, 2026-09-19: src/utils/expediente-validation.ts is UNTOUCHED since 2c1675f6 (09-08, the commit that wrote the test), and it normalizes the literal expediente in the fixture to a valid form. That eliminates the branch that mattered - the expediente field itself is not regressed. colectivo-expediente fails at :74 on assert.equal((await actions.crearColectivo(createInput(literal))).success, true) returning false. Two commits landed AFTER the test and added requirements the fixtures never satisfied: 9b734f9a (09-15 'Require valid line for colectivos') and c53ebba5 (09-13 'Require expediente for collective modifications'); createInput carries no linea, and the third test edits with an empty expediente. That points at stale fixtures. STILL INFERRED FROM COMMIT TITLES, NOT MEASURED - audit says so itself and it is not closed on that basis. DECISIVE CHECK, to run before touching anything: print the returned error/code from crearColectivo in the harness. success:false does not say WHICH gate rejected, and 9b734f9a and c53ebba5 are two different gates - the error code discriminates them, the titles only make them plausible. CONSTRAINT ON THE FIX: a fixture is updated ONLY after the error code names the gate. Adding a linea to createInput because a commit title mentions lineas makes the test green either way, including over a real regression - that is updating the test to match the behaviour, which is how a regression becomes the spec. The colectivo-save-errors failure is explained by NOTHING either lane has measured and may be a third cause; it is not covered by the stale-fixture reading.
-
coder03assistant-mba-l-ca
-
Re-measuring the four historical failures against current code; no test execution by this lane
-
2026-10-08 source/commit review: the old expediente literal regressions were addressed by MOVILBA-362 (commit 81ba703c; tests assert raw literal preservation on create/edit), and the formerly optional edit date is now deliberately required by MOVILBA-288 (7ab3e030; fixture supplies the decided date). Current shared tools/tests/colectivo-expediente.test.cjs is dirty with MOVILBA-546/349/637 work and now has line/category/date cases; I did not alter it. tools/tests/colectivo-save-errors.test.cjs has no working-tree diff; this lane did not run test:tools. Need audit to run the tools gate on current tree and name any residual failure, especially save rejection, before deciding whether a source fix or fixture update is warranted. No behavior changed.
-
Full pnpm test:tools on current shared tree: 113/113 pass, 0 fail. pnpm typecheck: clean. None of the four historical failures (incl. save-rejection) reproduce. colectivo-edit-load.test.cjs dropdown-fixture fix (coder04, carroceriaCategorias key + negative control) confirmed green. tools/tests/colectivo-expediente.test.cjs left untouched (carries another lane's uncommitted MOVILBA-546/349/637 edits, out of scope here).
-
Closed: audit ran test:tools 113/113 and typecheck clean on current tree; none of the four failures described from 2026-09-19 reproduce, including save-rejection. The expediente literal/date cases were superseded by MOVILBA-362/MOVILBA-288 and the current suite. No code changes from this lane.