gitdeployprod.sh v2.3 blocks itself: rewrites .gitdeployprod-pre.sh INFO_VERSION stamp, then fails 'Uncommitted changes'; gitdeploydev --only leaves regenerated CHANGELOG.md dirty
Measured 2026-09-17 23:20 in worktrees/dev (clean, at origin/dev). (1) gitdeployprod.sh v2.3 calls ensure_prehook_info_version (line 131/143) which rewrites the '# GITDEPLOYPROD_INFO_VERSION=' line in .gitdeployprod-pre.sh from 2.2 to 2.3, then line 171 refuses: 'Uncommitted changes. Run gitdeploydev.sh first.' Every first prod deploy after a script version bump fails on its own edit. Workaround used: gitdeploydev --only .gitdeployprod-pre.sh (d3a87b45). Fix: stamp the pre-hook inside the same commit the script makes, or validate cleanliness BEFORE stamping and include the stamp in the merge. (2) gitdeploydev.sh regenerates CHANGELOG.md (tools/gen-changelog.sh) before committing, but with --only the file is not part of the commit, so every --only deploy leaves CHANGELOG.md modified in the worktree and the next gitdeployprod refuses. Workaround: git checkout -- CHANGELOG.md. Fix: always include CHANGELOG.md in the deploy commit (it is generated output, never hand-edited), or generate it after the commit and amend/skip. Owner per MOVILBA-460 vendoring: deploy-engines.
Activity
-
PROD deploy done via workaround: d3a87b45 (pre-hook stamp) + git checkout -- CHANGELOG.md, then gitdeployprod.sh -> main 2f21437e v5.5.223, PROD /api/health serviceId 31462 = 5.5.223.
-
coder04-mba-l-ca
-
Taking MOVILBA-476 to verify whether the deployed script behavior still exists in the current shared branch.
-
Current shared branch is already clear by source inspection. The old gitdeployprod.sh/.gitdeployprod-pre.sh path is absent; mba-deploy-prod.sh checks clean tracked/index state at lines 35-41 before environment loading or gates and contains no pre-hook version rewrite. mba-deploy-dev.sh regenerates CHANGELOG.md at :109, stages it at :156-158 when changed, and adds it to RUN_PATHS before mba_cs_stage, including --only. Both symptoms are superseded by the MovilBA-owned deployment scripts introduced in f90ef53a (MOVILBA-460). No code change or deploy simulation performed.
-
Resolved in current shared branch by MOVILBA-460: PROD checks cleanliness before any deploy work and no longer stamps the removed pre-hook; DEV stages regenerated CHANGELOG.md into the deploy commit, including --only. Source inspection only; no code change or deploy simulation.