mars
MARS-686
Remove approved-practica follow-up radiographs (unrequested feature)
Done high
cmcoder-mars-cc
Elazar directive 2026-08-31: remove the approved-practica follow-up radiograph feature. Reason in his words - Mars is a practica tracking and grading app, not an historia clinica; students do not upload x-rays outside a graded practica unless the client asks for it. The feature was self-originated by coder-mars-ca at 4713c06 with no WI, ticket, DM or instruction behind it (MARS-682); coder-mars-ca confirms it was the ONLY self-originated feature in its tenure, the other five commits being remediation.
Activity
-
CLOSED. Shipped 20de571 v2.79.18, PASS:20de571 deep from audit-mars-ca (tag audit-mars-ca-mth15a5jnyhk): full repo reference scan finds no follow-up radiograph symbol, predicate or reference; page.tsx removal leaves its imports used; the retained profile-image FormData stub is independent of the removed feature. Removed: followup-radiograph-action.ts, followup-radiograph-control.tsx and both test files; page.tsx import, canAddFollowupRadiograph predicate and JSX block. KEPT deliberately: the vitest/jsdom FormData harness fix in src/app/api/profile-image/route.test.ts, which rode in on 4713c06 but belongs to the profile-image route and is unrelated to the feature - audit confirmed keeping it was correct. Vitest 740/740 (6 fewer, the feature's own tests), tsc clean, eslint clean. PTD: live 2.79.18 == REMOTE main 2.79.18 (dpl_26CKvUyFwt7sfbiVjr6oDBwH9dMn) via gh api. This supersedes MARS-683's fixes: the code audit passed at ce0e232 and 439749a is now deleted rather than repaired. Recording that explicitly so the earlier PASSes are never read as describing live code. DATA LEFT IN PLACE by Elazar's decision, not oversight: practicaImages row a0f7a02c-286f-4515-a0f0-041685b9d23b (label 'Reevaluacion a los 3 meses', image 2026_4bd5ee55-8b78-44d4-b619-09c0eb19373d) on practica fd5cbc3a-daeb-4d71-be2b-5a53e73c6f20, uploaded 2026-08-27 by the one student who used the feature. It is mechanically identical to the four ordinary images on that practica - same uploadImage() API, same storage, same tooth scope, sortOrder 4 - and still renders as a normal practica image. The upload path is gone so nothing new can arrive, and Elazar states all Mars files are purged each March before classes start, which is the cleanup. MARS-684 (Postgres-boundary refactor of the same action) is now OBSOLETE - the action no longer exists. Cancelling it.
chore
6w ago by wi-cli-venus
6w ago
2026-08-31 09:22